Pull request #45 breaks Makefile

[ghost]

The cbee707 commit pulled in with #45 breaks Makefile.

This involves a
-$(GITHG_F): $(GITHG_S)
+$(GITHG_F): $(HGFE_D)
change which in turn make $< in rule
$(SED) 's|GITHG_HOME=.*|GITHG_HOME=$(GITHGEXECDIR)|' $< > $@
resolve to fast-export rather than bin/git-hg

Which is wrong and it causes this to happen:

$ make
rm -rf fast-export
git submodule update --init
Submodule path 'fast-export': checked out 'f2491e83b038a27bc4a64a34b4bccb557734ab3a'
mkdir -p build
sed 's|GITHG_HOME=.*|GITHG_HOME=/usr/local/lib/git-hg|' fast-export > build/git-hg
sed: read error on fast-export: Is a directory
make: *** [build/git-hg] Error 4

[meekrosoft]

I am facing this issue on cygwin also. When I run git-hg afterwards it still seems to work though. Is it safe to continue working this way?

[ghost]

It appears so, yes. The bug makes the Makefile useless, but otherwise the unmodified git-hg should be fully functional. The failed sed command affects the search order for hg-fast-export, but in any case git-hg will spew out errors if it can't find it.

So unless you get "error: executable not found, hg-fast-export.sh", it's perfectly safe.

[meekrosoft]

Thanks for the confirmation!