Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Params Failed #22341

Closed
harrybite opened this issue Oct 23, 2024 · 5 comments
Closed

Updating Params Failed #22341

harrybite opened this issue Oct 23, 2024 · 5 comments
Assignees

Comments

@harrybite
Copy link

I have created a module called 'Identity' with some custom msgs and prefix (I changed the prefix from 'cosmos' to 'ssi')

I am trying to update the Params of my module but the transaction is failing every time with this error

Image

I have gone through the documentation also https://docs.cosmos.network/v0.50/build/modules/gov#proposal-submission
which says everyone can send the proposal, but in my case I don't know what's going wrong.

I also followed this ignite tutorial https://tutorials.ignite.com/use-governance-correctly-to-upgrade-your-blockchain and sent an UpdateParamsMsg for my custom module but I still had the same error.

I checked the code and found that the error is coming from https://github.com/cosmos/cosmos-sdk/blob/main/x/gov/keeper/proposal.go#L102.
When I initialize the chain it does not have any flag which can set gov account. Is the gov account address hard coded in any file?

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK Oct 23, 2024
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Oct 23, 2024
@tac0turtle
Copy link
Member

In your custom module are you setting the authority to gov or another account?

the gov address is predictable, when constructing the message that gov needs to execute the signer of the message needs to be gov address, this is why its failing. Can you post the message you are trying to execute

@tac0turtle tac0turtle added T:question and removed needs-triage Issue that needs to be triaged labels Oct 23, 2024
@tac0turtle tac0turtle self-assigned this Oct 23, 2024
@harrybite
Copy link
Author

@tac0turtle I used this command to send the transaction

Image

proposal.json file contains this stuff

Image

I have not set authority to any account. it defaults to the governance module, right ??

Image

or I have to set the authority from somewhere else in the code ?

@tac0turtle
Copy link
Member

how are you handling parameters? through the params module or directly in your module?

@harrybite
Copy link
Author

@tac0turtle Ahh, I could not understand what you mean by handling parameters. I am trying to update my module parameter which is currently only one, and I am using that inside my module.

I also tried to submit the proposal to update the minting parameters but still got the same error.

@harrybite
Copy link
Author

Okay, so I fixed this by changing the authority.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🥳 Done in Cosmos-SDK Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🥳 Done
Development

No branches or pull requests

2 participants