Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: allow to read the store v1 from store/v2 state commitment #22360

Closed
4 tasks
cool-develope opened this issue Oct 24, 2024 · 2 comments
Closed
4 tasks

[Feature]: allow to read the store v1 from store/v2 state commitment #22360

cool-develope opened this issue Oct 24, 2024 · 2 comments
Assignees
@tac0turtle
Labels
C:server/v2 Issues related to server/v2 C:Store T:feature-request

Comments

@cool-develope
Copy link
Contributor

cool-develope commented Oct 24, 2024 •
edited by tac0turtle
Loading

Summary

There are a couple of issues for the migration.

  • new store keys like stf are not loaded properly
  • SC metadata CommitInfo is not compatible with store/v1 metadata

Problem Definition

The migration from v1 to v2 is not working

Proposed Feature

  • SetInitialVersion for new store keys within factory.go or LoadVersionWithUpgrades in the server level
  • Refactor CommitInfo encoding/decoding to be compatible with store/v1
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK Legacy Oct 24, 2024
@cool-develope cool-develope mentioned this issue Oct 24, 2024
Merged
12 tasks
@julienrbrt
Copy link
Member

This looks similar to #22530

@tac0turtle tac0turtle added the C:server/v2 Issues related to server/v2 label Dec 3, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🥳 Done in Cosmos-SDK Legacy Dec 9, 2024
@tac0turtle tac0turtle reopened this Jan 6, 2025
@github-project-automation github-project-automation bot moved this from 🥳 Done to 📋 Backlog in Cosmos-SDK Legacy Jan 6, 2025
@tac0turtle tac0turtle self-assigned this Jan 6, 2025
@coderabbitai coderabbitai bot mentioned this issue Jan 7, 2025
Closed
12 tasks
@tac0turtle
Copy link
Member

this is completed

@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🥳 Done in Cosmos-SDK Legacy Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tac0turtle tac0turtle

Labels
C:server/v2 Issues related to server/v2 C:Store T:feature-request
Projects
No open projects
Cosmos-SDK Legacy
Status: 🥳 Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tac0turtle @julienrbrt @cool-develope