Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions for improving install process #42

Open
johnsaigle opened this issue Sep 21, 2022 · 0 comments
Open

Suggestions for improving install process #42

johnsaigle opened this issue Sep 21, 2022 · 0 comments

Comments

@johnsaigle
Copy link

The install.sh script seems to have been copied from the main gosec project. Trying to use it according to the instructions in the README does not work. The script itself points to the other repository.

Install script points to the wrong repository

The install script could be tackled in one of the 3 ways:

  • Modify the install script using godownloader. (However godownloader is abandoned).
  • Using the install script as a guide, modify it manually to point to this repository. Would also require publishing the corresponding binaries on the release page.
  • Delete the install script and instruct users to install from source

M1 support

In addition, the output of the install script will fail for Apple Silicon users (M1 and M2 chips) because it is not in the hard-coded list of supported architectures. Accordingly, it fails with a message that the architecture is not supported. However, it's possible to build and run the tool painlessly using a simple make if one downloads the source.

Support could be added by adding a line to the install script for darwin/arm64. I don't think this architecture and OS combination existed when this install script was written.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant