Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc-gateway support? #307

Open
tac0turtle opened this issue Mar 25, 2021 · 4 comments
Open

grpc-gateway support? #307

tac0turtle opened this issue Mar 25, 2021 · 4 comments

Comments

@tac0turtle
Copy link
Member

Summary

grpc-gateway was added as a stop gap to gRPC and REST. This begs the question in the design of this repo do we need to support grpc-gateway?

Maybe we only support grpc-gateway for queries and txs can only be used with gRPC?

Would like to hear thoughts of other people involved in this repo.
@fedekunze
Copy link
Collaborator

Maybe we only support grpc-gateway for queries and txs can only be used with gRPC?

I think this is how it's done on the SDK modules

@tac0turtle
Copy link
Member Author

I think this is how it's done on the SDK modules

Oh you're right. Are we fine with supporting on queries or we want to remove that?

@fedekunze
Copy link
Collaborator

let's support queries 👍

@fedekunze
Copy link
Collaborator

can you create an issue on the SDK for the tx support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tac0turtle @fedekunze