Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor WriteAcknowledgement to take in the packetID rather than the entire packet #6635

Open
3 tasks
colin-axner opened this issue Jun 18, 2024 · 2 comments
Open
3 tasks

Refactor WriteAcknowledgement to take in the packetID rather than the entire packet #6635

colin-axner opened this issue Jun 18, 2024 · 2 comments
Labels
change: api breaking Issues or PRs that break Go API (need to be release in a new major version) needs discussion Issues that need discussion before they can be worked on type: performance Performance or storage optimizations type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Milestone
v10.0.0

Comments

@colin-axner
Copy link
Contributor

Summary

WriteAcknowledgement only uses the packetID information provided in the packet arg, except when emitting events. Though, there is open issue #5901 to remove the unnecessary attributes emitted (non packetID info). We should change the packet arg to be a packetID instead. This allows async application to only store the packetID rather than the entire packet which improves storage performance

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added type: performance Performance or storage optimizations needs discussion Issues that need discussion before they can be worked on type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. change: api breaking Issues or PRs that break Go API (need to be release in a new major version) labels Jun 18, 2024
@colin-axner colin-axner mentioned this issue Jun 18, 2024
Open
3 tasks
@colin-axner colin-axner added this to the v9.0.0 milestone Jun 18, 2024
This was referenced Jun 19, 2024
Merged
Closed
@bznein bznein self-assigned this Jun 20, 2024
@colin-axner
Copy link
Contributor Author

Heads up, this will require #6653 which requires changes in hermes (and likely changes to MsgAcknowledgement to take in just the packetID as opposed to the full packet)

@colin-axner colin-axner modified the milestones: v9.0.0, v10.0.0 Jul 3, 2024
@colin-axner
Copy link
Contributor Author

This issue is on hold until informalsystems/hermes#4078 is addressed. I have moved the issue out of the v9 milestone and into v10, but the exact release it can be addressed in is dependent on the relayers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
change: api breaking Issues or PRs that break Go API (need to be release in a new major version) needs discussion Issues that need discussion before they can be worked on type: performance Performance or storage optimizations type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
ibc-go
Status: On hold ❌
Milestone
v10.0.0
Development

No branches or pull requests
2 participants
@bznein @colin-axner