You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please do not remove this constant from the ibctesting package as I'm using it in external crates. Maybe the issue should be renamed to Remove/Revisit the usage of ibctesting.FirstChannelID since the constant is appropriately named?
Yeah I think keeping the constant in place is doing no harm to not mess with external dependencies on it. As long as our tests are updated to not rely on it, I think it's fine to keep.
ibctesting.FirstChannelID
used to be a valid constant to represent channels used in testing. However, after #6748, this is not true anymore.We should revisit all occurrences of this constant and either:
The text was updated successfully, but these errors were encountered: