Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a way to query for acknowledgements in e2e tests #6786

Closed
bznein opened this issue Jul 9, 2024 · 3 comments · Fixed by #6802
Closed

Add a way to query for acknowledgements in e2e tests #6786

bznein opened this issue Jul 9, 2024 · 3 comments · Fixed by #6802
Assignees
@PanGan21
Labels
e2e nice-to-have

Comments

@bznein
Copy link
Contributor

bznein commented Jul 9, 2024

Context here: #6778 (comment)
@bznein bznein mentioned this issue Jul 9, 2024
Merged
10 tasks
@crodriguezvega crodriguezvega changed the title (test) - Add a way to query for acknowledgements in e2e tests Add a way to query for acknowledgements in e2e tests Jul 9, 2024
@PanGan21
Copy link
Contributor

PanGan21 commented Jul 9, 2024

Hey guys, could I give it a try?

@crodriguezvega
Copy link
Contributor

Hey guys, could I give it a try?

Yes, definitely. Thank you, @PanGan21!

@damiannolan
Copy link
Member

Is the request here to be able to query the acknowledgement commitment or have full access to the data type?

There is QueryPacketAcknowledgement here.

If we want access to the full acknowledgement data, then it can be parsed from the events in the tx response from BroadcastMsgs in e2e.

@PanGan21 PanGan21 mentioned this issue Jul 11, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PanGan21 PanGan21

Labels
e2e nice-to-have
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Assert packet acknowledgement in e2e tests PanGan21/ibc-go
4 participants
@damiannolan @crodriguezvega @bznein @PanGan21