Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistently name context variable #7702

Closed
4 tasks
DimitrisJim opened this issue Dec 17, 2024 · 6 comments
Closed
4 tasks

Consistently name context variable #7702

DimitrisJim opened this issue Dec 17, 2024 · 6 comments
Labels
good first issue Good for newcomers nice-to-have type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@DimitrisJim
Copy link
Contributor

DimitrisJim commented Dec 17, 2024 •
edited
Loading

Ref #7261 (comment)

minor nit for naming these context vars with consistency ctx/goCtx

Would be nice to use same names across the board to avoid confusion.

Should be done after #7261 and relevant PRs for it are merged.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
  • Estimate provided
@DimitrisJim DimitrisJim added the type: code hygiene Clean up code but without changing functionality or interfaces label Dec 17, 2024
@DimitrisJim DimitrisJim mentioned this issue Dec 17, 2024
Merged
10 tasks
@iIvaki
Copy link
Contributor

iIvaki commented Dec 17, 2024

@DimitrisJim can I do this?

@DimitrisJim
Copy link
Contributor Author

Sure, Please wait for Environment prs to land first though! Ideally, should pick this up when #7712 is closed!

@technicallyty
Copy link
Collaborator

can we remove this from the olympus epic? trying to slim down the epic to whats strictly necessary

@gjermundgaraba
Copy link
Contributor

Yeah, good point! Removing it from the epic and marking as nice-to-have

@hungdinh82
Copy link
Contributor

@gjermundgaraba does this issue still need to be resolved?

@gjermundgaraba
Copy link
Contributor

gjermundgaraba commented Feb 17, 2025 •
edited
Loading

No, this is not needed anymore. Need to clean up here :D

@github-project-automation github-project-automation bot moved this from Backlog to Done in IBC-GO Eureka Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers nice-to-have type: code hygiene Clean up code but without changing functionality or interfaces
Projects
IBC-GO Eureka
Status: Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@gjermundgaraba @DimitrisJim @technicallyty @hungdinh82 @iIvaki