Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add packet acknowledgements rpc #7558

Open
wants to merge 1 commit into
base: feat/ibc-eureka
Choose a base branch
from
Open

chore: add packet acknowledgements rpc #7558

wants to merge 1 commit into from

Conversation

DimitrisJim
Copy link
Contributor

@DimitrisJim DimitrisJim commented Nov 13, 2024 •
edited
Loading

Description

ref: #7478

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@DimitrisJim DimitrisJim marked this pull request as draft November 13, 2024 09:56
@DimitrisJim DimitrisJim mentioned this pull request Nov 13, 2024
Open
13 tasks
@DimitrisJim DimitrisJim force-pushed the jim/packet-acks-rpc branch 3 times, most recently from 712a1d6 to 24ea202 Compare November 13, 2024 12:24
@DimitrisJim DimitrisJim marked this pull request as ready for review November 13, 2024 12:24
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 21, 2024

Quality Gate Passed Quality Gate passed for 'ibc-go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

gjermundgaraba
gjermundgaraba reviewed Nov 22, 2024
View reviewed changes
modules/core/04-channel/v2/keeper/grpc_query_test.go
expError error
}{
{
"success",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe the name could be a bit more descriptive since it tests some quite specific behavior? Something like this?

Suggested change
"success",
"success: with PacketCommitmentSequences",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjermundgaraba gjermundgaraba gjermundgaraba approved these changes

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@damiannolan damiannolan Awaiting requested review from damiannolan damiannolan is a code owner

@chatton chatton Awaiting requested review from chatton chatton is a code owner

Assignees
No one assigned
Labels
None yet
Projects
IBC-GO Eureka
Status: In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DimitrisJim @gjermundgaraba