Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from tendermint-proto to cometbft-proto dependency #189

Open
adizere opened this issue Feb 2, 2024 · 1 comment · May be fixed by #190
Open

Migrate from tendermint-proto to cometbft-proto dependency #189

adizere opened this issue Feb 2, 2024 · 1 comment · May be fixed by #190
Assignees
@adizere

Comments

@adizere
Copy link
Contributor

adizere commented Feb 2, 2024

Work in tandem with:
@adizere adizere self-assigned this Feb 2, 2024
@adizere adizere linked a pull request Feb 2, 2024 that will close this issue
Draft
@mzabaluev
Copy link
Contributor

As described in cosmos/ibc-rs#1073 (comment), there is a somewhat hacky way forward that does not need waiting for upstream protos to convert to buf.build/cometbft/cometbft:

  1. Fix tendermint proto imports are not consistent between cosmos-sdk and ibc-rs revisions #194 by adjusting the upstream commits.
  2. Remap the tendermint.* packages to versioned module paths in cometbft_proto using the extern_path option of prost-build.

@adizere adizere changed the title Migrate from tendermint-proto to cometbft-proto depdency Migrate from tendermint-proto to cometbft-proto dependency Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adizere adizere

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

First stab at migrating to CometBFT-rs cosmos/ibc-proto-rs
2 participants
@mzabaluev @adizere