Merge branch 'main' into feat/refactor-testkit

.changelog/unreleased/breaking-changes/1114-refactor-client-relevant-apis.md

@@ -0,0 +1,3 @@
+- [ibc] Refactor client relevant APIs for improved modularity and allow
+  standalone ICS-02 integration
+  ([\#1114](https://github.com/cosmos/ibc-rs/issues/1114))

.changelog/unreleased/breaking-changes/1118-bump-msrv.md

@@ -0,0 +1,2 @@
+- [ibc] Increase minimum supported Rust version to 1.71.1
+  ([\#1118](https://github.com/cosmos/ibc-rs/issues/1118))

.changelog/unreleased/bug-fixes/1100-fix-tendermint-empty-proof-specs-check.md

@@ -0,0 +1,2 @@
+- [ibc-client-tendermint-types] Check ics23 proof specs for empty depth range.
+  ([\#1100](https://github.com/cosmos/ibc-rs/issues/1100))

.changelog/unreleased/improvements/1074-refactor-default-implemetation.md

@@ -0,0 +1,2 @@
+- [types] Refactor `Default` implementations with concrete names
+  ([\#1074](https://github.com/cosmos/ibc-rs/issues/1074))

.changelog/unreleased/improvements/1101-use-let-else-over-downcast.md

@@ -0,0 +1,2 @@
+- [ibc-primitives] Use `let-else` over `downcast!()` and remove `utils/macros`
+  module as a result ([\#1118](https://github.com/cosmos/ibc-rs/issues/1118))

.changelog/unreleased/improvements/1120-rm-redundant-shadowing.md

@@ -0,0 +1,2 @@
+- [ibc-core] Remove unnecessary shadowing with same value
+  ([\#1120](https://github.com/cosmos/ibc-rs/issues/1120))

.github/workflows/coverage.yml

@@ -14,6 +14,8 @@ on:
       - ibc-clients/**
       - ibc-primitives/**
       - ibc-query/**
+      - ibc-testkit/**
+      - ibc-derive/**
   push:
     branches:
       - main

.github/workflows/cw-check.yaml

@@ -3,6 +3,8 @@ on:
   pull_request:
     paths:
       - .github/workflows/cw-check.yml
+      - Cargo.toml
+      - Cargo.lock
       - ci/cw-check/**
   push:
     tags:
@@ -22,7 +24,6 @@ on:
       - ibc-data-types/**
       - ibc-clients/**
       - ibc-primitives/**
-      - ibc-query/**
       - ibc-derive/**
 jobs:
   cw-check:

.github/workflows/no-std.yaml

@@ -13,6 +13,7 @@ on:
       - ibc-data-types/**
       - ibc-clients/**
       - ibc-primitives/**
+      - ibc-derive/**
   push:
     branches: main
     paths:
@@ -27,6 +28,7 @@ on:
       - ibc-data-types/**
       - ibc-clients/**
       - ibc-primitives/**
+      - ibc-derive/**
 jobs:
   check-no-std-panic-conflict:
     name: Check no_std panic conflict

.github/workflows/rust.yml

@@ -157,3 +157,48 @@ jobs:
         with:
           command: test
           args: --no-default-features --no-fail-fast --no-run
+
+  test-msrv:
+    timeout-minutes: 30
+    env:
+      CARGO_MSRV_VERSION: 0.16.0-beta.20
+      MSRV: 1.71.1
+    strategy:
+      matrix:
+        param:
+          [
+            { os: ubuntu-latest, system: unknown-linux-gnu },
+            { os: macos-latest, system: apple-darwin },
+          ]
+    runs-on: ${{ matrix.param.os }}
+    steps:
+      - uses: actions/checkout@v2
+
+      - name: Download cargo-msrv
+        uses: dsaltares/fetch-gh-release-asset@master
+        with:
+          repo: foresterre/cargo-msrv
+          version: "tags/v${{ env.CARGO_MSRV_VERSION }}"
+          file: "cargo-msrv-x86_64-${{ matrix.param.system }}-v${{ env.CARGO_MSRV_VERSION }}.tgz"
+
+      - uses: actions-rs/toolchain@v1
+        with:
+          toolchain: ${{ env.MSRV }}
+          override: true
+      - uses: Swatinem/rust-cache@v1
+
+      - name: Install cargo-msrv
+        run: |
+          tar -xzf "cargo-msrv-x86_64-${{ matrix.param.system }}-v${{ env.CARGO_MSRV_VERSION }}.tgz"
+          mv "cargo-msrv-x86_64-${{ matrix.param.system }}-v${{ env.CARGO_MSRV_VERSION }}/cargo-msrv" ~/.cargo/bin
+          cargo msrv --version
+
+      - name: Calculate MSRV
+        run: cargo msrv --output-format minimal --min 1.64.0
+
+      - name: Build with MSRV
+        uses: actions-rs/cargo@v1
+        with:
+          toolchain: ${{ env.MSRV }}
+          command: build
+          args: --all-features

Cargo.toml

@@ -43,7 +43,7 @@ exclude = [
 version      = "0.50.0"
 license      = "Apache-2.0"
 edition      = "2021"
-rust-version = "1.64"
+rust-version = "1.71.1"
 readme       = "README.md"
 repository   = "https://github.com/cosmos/ibc-rs"
 authors      = ["Informal Systems <[email protected]>"]

README.md

@@ -16,9 +16,9 @@
 [![Build Status][build-image]][build-link]
 [![Code Coverage][codecov-image]][codecov-link]
 [![Apache 2.0 Licensed][license-image]][license-link]
-![Rust Stable][rustc-image]
-![Rust 1.64+][rustc-version]
-![Lines of Code][loc-image]
+![Version][crates-io-version]
+![Downloads][crates-io-downloads]
+![Rust Stable][msrv-image]
 
 </div>
 </div>
@@ -94,11 +94,11 @@ specific language governing permissions and limitations under the License.
 [build-link]: https://github.com/cosmos/ibc-rs/actions?query=workflow%3ARust
 [codecov-image]: https://codecov.io/gh/cosmos/ibc-rs/branch/main/graph/badge.svg?token=wUm2aLCOu
 [codecov-link]: https://codecov.io/gh/cosmos/ibc-rs
-[loc-image]: https://tokei.rs/b1/github/cosmos/ibc-rs
-[license-image]: https://img.shields.io/badge/license-Apache2.0-blue.svg
+[license-image]: https://img.shields.io/crates/l/ibc
 [license-link]: https://github.com/cosmos/ibc-rs/blob/main/LICENSE
-[rustc-image]: https://img.shields.io/badge/rustc-stable-blue.svg
-[rustc-version]: https://img.shields.io/badge/rustc-1.60+-blue.svg
+[crates-io-version]: https://img.shields.io/crates/v/ibc.svg
+[crates-io-downloads]: https://img.shields.io/crates/d/ibc.svg
+[msrv-image]: https://img.shields.io/crates/msrv/ibc
 
 [//]: # (general links)
 [ibc]: https://github.com/cosmos/ibc

ci/cw-check/rust-toolchain.toml

@@ -1,5 +1,5 @@
 [toolchain]
-channel = "nightly-2023-03-09"
+channel = "nightly-2024-02-24"
 targets = [
   "wasm32-unknown-unknown",
 ]

ci/cw-check/src/lib.rs

@@ -36,7 +36,7 @@ pub fn instantiate(
     let d =
         serde_json::to_string(&ConnectionId::from_str(msg.test.as_str()).unwrap()).expect("test");
     let e = serde_json::to_string(&PrefixedDenom {
-        trace_path: TracePath::default(),
+        trace_path: TracePath::empty(),
         base_denom: BaseDenom::from_str(msg.test.as_str()).unwrap(),
     })
     .expect("test");

clippy.toml

@@ -7,3 +7,4 @@ disallowed-types = [
 disallowed-methods = [
     "std::time::Duration::as_secs_f64",
 ]
+msrv = "1.71.1"

docs/architecture/adr-005-handlers-redesign.md

@@ -296,7 +296,7 @@ trait ValidationContext {
     /// Function required by ICS 03. Returns the list of all possible versions that the connection
     /// handshake protocol supports.
     fn get_compatible_versions(&self) -> Vec<Version> {
-        get_compatible_versions()
+        ConnectionVersion::compatibles()
     }
 
     /// Function required by ICS 03. Returns one version out of the supplied list of versions, which the