Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Counterparty for connections and channels must not have any Option<> type #142

Closed
5 tasks
plafer opened this issue Oct 5, 2022 · 2 comments
Closed
5 tasks
Assignees

Comments

@plafer
Copy link
Contributor

plafer commented Oct 5, 2022

Summary of Bug

The Counterparty structs should look like:

/// Connection
pub struct Counterparty {
    client_id: ClientId,
    pub connection_id: ConnectionId, // currently `Option<ConnectionId>`
    prefix: CommitmentPrefix,
}

/// Channel
pub struct Counterparty {
    pub port_id: PortId,
    pub channel_id: ChannelId, // currently `Option<ChannelId>`
}

In other words, a Counterparty must have a valid connection/channel id. The current version is incorrect.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@plafer plafer self-assigned this Oct 5, 2022
@plafer
Copy link
Contributor Author

plafer commented Oct 5, 2022

To be implemented when we remove the crossing hellos logic (#143).

@plafer
Copy link
Contributor Author

plafer commented Oct 21, 2022

This is not true. The {connection,channel}_id will be None after OpenInit.

@plafer plafer closed this as completed Oct 21, 2022
@plafer plafer closed this as not planned Won't fix, can't repro, duplicate, stale Oct 21, 2022
shuoer86 pushed a commit to shuoer86/ibc-rs that referenced this issue Nov 4, 2023
* Bump Rust version to v0.10.0

* Update changelog

* Update changelog

* Bump JS package version to 0.7.0

* Use Codecov token to upload Rust coverage

* Bump TS package to 0.10.0 to align it with the Go and Rust implementations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant