-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add needed unit or integration tests for Tendermint proof verifications #398
Comments
#396 was a core IBC bug; not Tendermint-specific. Did you mean "core handler validation needs to be tested" instead of "Tendermint proof verifications"? |
It occurred in the core section, but catching such errors needs that tests go through a proof verification process (e.g. here), which is a client-specific action. So, we can match the output with the fed test data. |
Ah I see; yes that's right. |
closed by #1109 |
Summary
There is a need to cover Tendermint proof verifications with proper tests after issue #396.
Mock Chain passes the proof verifications and we are not able to catch Tendermint-specific errors with the existing tests.
To Do
To ensure Tendermint proof verifications are correctly executed, we should add corresponding unit tests or somehow integrate
basecoin-rs
into our CI processBlocked on: #677
The text was updated successfully, but these errors were encountered: