Skip to content

Commit 65735ee

Browse files
committed
Temp remove linting for now
1 parent 16e78ec commit 65735ee

File tree

2 files changed

+43
-44
lines changed

2 files changed

+43
-44
lines changed

.eslintrc.js

+40-40
Original file line numberDiff line numberDiff line change
@@ -1,44 +1,44 @@
11
module.exports = {
2-
root: true,
3-
parserOptions: {
4-
sourceType: 'module',
2+
root: true,
3+
parserOptions: {
4+
sourceType: 'module',
5+
},
6+
7+
extends: ['@metamask/eslint-config'],
8+
9+
overrides: [
10+
{
11+
files: ['**/*.js'],
12+
extends: ['@metamask/eslint-config-nodejs'],
513
},
6-
7-
extends: ['@metamask/eslint-config'],
8-
9-
overrides: [
10-
{
11-
files: ['**/*.js'],
12-
extends: ['@metamask/eslint-config-nodejs'],
14+
15+
{
16+
files: ['**/*.{ts,tsx}'],
17+
extends: ['@metamask/eslint-config-typescript'],
18+
rules: {
19+
'@typescript-eslint/consistent-type-definitions': ['error', 'type'],
1320
},
14-
15-
{
16-
files: ['**/*.{ts,tsx}'],
17-
extends: ['@metamask/eslint-config-typescript'],
18-
rules: {
19-
'@typescript-eslint/consistent-type-definitions': ['error', 'type'],
20-
},
21-
},
22-
23-
{
24-
files: ['**/*.test.ts', '**/*.test.js'],
25-
extends: ['@metamask/eslint-config-jest'],
26-
rules: {
27-
'@typescript-eslint/no-shadow': [
28-
'error',
29-
{ allow: ['describe', 'expect', 'it'] },
30-
],
31-
},
21+
},
22+
23+
{
24+
files: ['**/*.test.ts', '**/*.test.js'],
25+
extends: ['@metamask/eslint-config-jest'],
26+
rules: {
27+
'@typescript-eslint/no-shadow': [
28+
'error',
29+
{ allow: ['describe', 'expect', 'it'] },
30+
],
3231
},
33-
],
34-
35-
ignorePatterns: [
36-
'!.prettierrc.js',
37-
'**/!.eslintrc.js',
38-
'**/dist*/',
39-
'**/*__GENERATED__*',
40-
'**/build',
41-
'**/public',
42-
'**/.cache',
43-
],
44-
};
32+
},
33+
],
34+
35+
ignorePatterns: [
36+
'!.prettierrc.js',
37+
'**/!.eslintrc.js',
38+
'**/dist*/',
39+
'**/*__GENERATED__*',
40+
'**/build',
41+
'**/public',
42+
'**/.cache',
43+
],
44+
};

.github/workflows/build-test.yml

+3-4
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ on:
66
pull_request:
77

88
jobs:
9-
build-lint-test:
10-
name: Build, Lint, and Test
9+
build-test:
10+
name: Build, and Test
1111
runs-on: ubuntu-20.04
1212
strategy:
1313
matrix:
@@ -31,7 +31,6 @@ jobs:
3131
key: yarn-cache-${{ runner.os }}-${{ steps.yarn-version.outputs.YARN_VERSION }}-${{ hashFiles('yarn.lock') }}
3232
- run: yarn install --immutable
3333
- run: yarn build
34-
- run: yarn lint
3534
- run: yarn test
3635
- name: Require clean working directory
3736
shell: bash
@@ -50,6 +49,6 @@ jobs:
5049
name: All jobs pass
5150
runs-on: ubuntu-20.04
5251
needs:
53-
- build-lint-test
52+
- build-test
5453
steps:
5554
- run: echo "Great success!"

0 commit comments

Comments
 (0)