Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON parsing in ICS20 is key-order dependent and strict #22

Open
gjermundgaraba opened this issue Aug 7, 2024 · 0 comments
Open

JSON parsing in ICS20 is key-order dependent and strict #22

gjermundgaraba opened this issue Aug 7, 2024 · 0 comments
Labels
enhancement Improvements

Comments

@gjermundgaraba
Copy link
Contributor

gjermundgaraba commented Aug 7, 2024

The current implementation of the ICS20Lib requires the keys in the transfer packet data JSON to be in a specific order. If any keys are out of order, the parsing fails.

If we found a way to support parsing it in any order, it would be great, but we need to consider the gas cost, and ideally keep the best-case scenario to more or less the same gas as now.

Another issue is that the JSON parsing would fail if there are any missing or added fields. The only optional field at this point is the memo field. So we should figure out what we want to allow for and update that.

@gjermundgaraba gjermundgaraba added the enhancement Improvements label Aug 7, 2024
@gjermundgaraba gjermundgaraba changed the title JSON parsing in ICS20 is key-order dependent JSON parsing in ICS20 is key-order dependent and strict Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements
Projects
None yet
Development

No branches or pull requests

2 participants