Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspect status for EVERY call into lcb #95

Open
chvck opened this issue Dec 9, 2020 · 1 comment
Open

Inspect status for EVERY call into lcb #95

chvck opened this issue Dec 9, 2020 · 1 comment

Comments

@chvck
Copy link
Collaborator

chvck commented Dec 9, 2020

We've recently hit an issue which looked like an lcb issue but after investigation thanks to @avsej it has been identified that we aren't checking the status code return from lcb calls. We should be checking this (and using lcb_strerror_short to make errors human readable) for EVERY call.

@daschl
Copy link
Contributor

daschl commented Dec 9, 2020

In addition to logging, it probably makes sense that if its on a request flow path to error the future properly with the right error.

daschl added a commit that referenced this issue Dec 9, 2020
This partially addresses #95 in that it covers the encode
path.
chvck pushed a commit that referenced this issue Dec 9, 2020
This partially addresses #95 in that it covers the encode
path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants