Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AngluarJS functionality - need some distro changes to make it official though. #54

Open
rolinger opened this issue Sep 5, 2017 · 1 comment

Comments

@rolinger
Copy link

rolinger commented Sep 5, 2017

This is the most comprehensive list that I have seen. Lets make it better though.

  1. I have written an angularJS components for this. But in order for users to only get what they need it would be best to separate the the country/city code list from the main repo. And then allow options for users to just grab updates to city/country codes as they happen. If you can do this I will post all the necessary code for the AngularJS implementation.

  2. Another issue for consistency is using two/three letter codes for regions/states - there are about 2 dozen that don't have 2 or 3 letter codes....those countries just have the city name and this is all. That poses a problem for Angular when building the $scopes needed for the select drop down menus. In order to fix this, I had to find all those country regions which didn't have a proper 2/3 letter code and basically make one up. In my app i only store the country or region codes...so if one doesn't exist it will break my implementation.

Aside from how I made up region/state codes, how else can this be addressed?

@rolinger rolinger changed the title Separate the country/city codes from main script Added AngluarJS function - need some distro changes to make it official though. Sep 5, 2017
@rolinger rolinger changed the title Added AngluarJS function - need some distro changes to make it official though. Added AngluarJS functionality - need some distro changes to make it official though. Sep 5, 2017
@ellenhutchings
Copy link

The country codes are already separated, and stored in a completely different repo, https://github.com/benkeen/country-region-data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants