Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch roles_map_file when started in watch mode #818

Closed
kevinsandow opened this issue Mar 26, 2024 · 3 comments
Closed

Watch roles_map_file when started in watch mode #818

kevinsandow opened this issue Mar 26, 2024 · 3 comments

Comments

@kevinsandow
Copy link
Contributor

At the moment watch mode only watches config files. In our use case we frequently change the role map during development.

If the role map was inlined in the config that would already work, but we want to use the feature to make the role map its own file.

Please watch those files as well, so we don't have to manually restart couper.

@kevinsandow kevinsandow changed the title Also watch roles_map_file when started in watch mode watch roles_map_file when started in watch mode Mar 26, 2024
@kevinsandow kevinsandow changed the title watch roles_map_file when started in watch mode Watch roles_map_file when started in watch mode Mar 26, 2024
@malud
Copy link
Collaborator

malud commented Mar 26, 2024

Thanks @kevinsandow. #747 has been merged a while ago. Could you please check if the edge/master version works as expected in your case?

@johakoch
Copy link
Collaborator

See also #697. Actually, I don't remember which attributes are affected by the fix implemented there...

@johakoch
Copy link
Collaborator

@kevinsandow Looks like this is already implemented in master, at least if you change the contents of an already existing file referenced by roles_map_file (and not change between roles_map_file and roles_map).

@malud malud closed this as completed Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants