Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug when exiting game (related to music implementation) #271

Open
FelipeMoleiro opened this issue Jan 10, 2022 · 1 comment
Open

Bug when exiting game (related to music implementation) #271

FelipeMoleiro opened this issue Jan 10, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@FelipeMoleiro
Copy link
Contributor

FelipeMoleiro commented Jan 10, 2022

Describe the bug

Displaying errors upon exit of game.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Start the game
  2. Quit it.

Message that appears:

System does not recognize call "system("killall mpg123")"
32 17.4M 32 5874k 0 0 46131 0 0:06:37 0:02:10 0:04:27 46131
curl: (23) Failure writing output to destination

Additional context

OS: Arch Linux

This is all related to the implementation of the music, which is pretty messy in my opinion. Using curl instead of sending the music to the data folder, and playing the song using system calls. Besides if we want to implement sound effects and other stuff this approach will become unbearable. I have a discussion open about this topic, but my sugestion was using SDL.

@FelipeMoleiro FelipeMoleiro added the bug Something isn't working label Jan 10, 2022
@lucasvianav
Copy link
Contributor

Also, I don't think it's good to call killall by program name. We should only kill the process we started, not all of the instances of mpg123 running in the system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants