Skip to content

Change the route when language is changed. #1950

Description

@manoj30075

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
I want to share a link to my uncle where he can read the page directly in Telugu(LANGUAGE). The problem with the present issue is the route is not changing when language is changed. This is becoming an issue for me to explain to my uncle how to change the language on the website.

Describe the solution you'd like
A clear and concise description of what you want to happen.
If the language is changed the route(link) has to be changed. So that the link including the language change is sharable.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Activity

  1. RisingGeek commented on May 30, 2020

    @RisingGeek

    I would like to /claim this issue.

  2. navkumar258 commented on Jun 26, 2020

    @navkumar258

    Hi, fixed a bug #2172 which scrolls to top whenever change the language button is clicked, it might make a better UX and also help ease in site accessibility. Hope it helps. Thanks 😄

  3. shuklaayush commented on Jul 3, 2020

    @shuklaayush
    Member

    /available

  4. github-actions commented on Jul 3, 2020

    @github-actions

    This issue is available for contribution.

    Please reply "/claim" (without quotes) if you wish to work on this issue.

  5. RisingGeek commented on Jul 3, 2020

    @RisingGeek

    /claim

  6. added
    Status: ClaimedIt's clear what the subject of the issue is about, and what the resolution should be
    and removed
    Status: AvailableReply with /claim to assign to you
    on Jul 3, 2020
  7. github-actions commented on Jul 3, 2020

    @github-actions

    Thank you @RisingGeek for claiming this issue! 🎉

    Please reference this issue when you submit your Pull Request and make sure you follow the contributing guidelines.

  8. removed their assignment
    on Jul 6, 2020
  9. added
    Status: AvailableReply with /claim to assign to you
    and removed
    Status: ClaimedIt's clear what the subject of the issue is about, and what the resolution should be
    on Jul 27, 2020
  10. khpatel8 commented on Jul 27, 2020

    @khpatel8

    /claim

  11. added
    Status: ClaimedIt's clear what the subject of the issue is about, and what the resolution should be
    and removed
    Status: AvailableReply with /claim to assign to you
    on Jul 27, 2020
  12. github-actions commented on Jul 27, 2020

    @github-actions

    Thank you @khpatel8 for claiming this issue! 🎉

    Please reference this issue when you submit your Pull Request and make sure you follow the contributing guidelines.

  13. khpatel8 commented on Jul 28, 2020

    @khpatel8

    is there a format that you would like to be followed when making a new route for language ?

  14. khpatel8 commented on Jul 29, 2020

    @khpatel8

    what i have implemented so far:

    (1) baselink takes you to (2) with default language english
    (2) baselink/[language name]/ : Home route
    (3) baselink/[language name]/about : about page (english only as per previous implementation)
    (4) baselink/blog as usual takes you to blog.covid19india.org

    **Do you want me to convert the language name to it's ISO code or just the full name is fine ? **

    If this all looks good, I can create a PR. Let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Status: ClaimedIt's clear what the subject of the issue is about, and what the resolution should be

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions