Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make getInstanceOptions works everywhere #642

Open
1 task
Crash-- opened this issue Feb 12, 2020 · 2 comments
Open
1 task

feat: Make getInstanceOptions works everywhere #642

Crash-- opened this issue Feb 12, 2020 · 2 comments

Comments

@Crash--
Copy link
Contributor

Crash-- commented Feb 12, 2020

ATM getInstanceOptions() only works on web application since it reads the content from the DOM. But it'll not work on mobile since the stack can't inject the data in the HTML.

getInstanceOptions should also work in a mobile application by calling the stack to have all the informations injected in the HTML. (mainly goal when writing this issue, knowing if the cozy is flat or nested. This kind of code will not work cozy/cozy-libs@d33345f#diff-81b87cd8e4fade0e86d13fae5c8324c6R26)

also see #586

@Ldoppea
Copy link
Member

Ldoppea commented Oct 20, 2021

Example of PR that manually implemented the checking : https://github.com/cozy/cozy-keys-browser/pull/134/files

Note that there was a mention about getCozyUrl() that exists in cozy-stack-client and seems not to be used a lot outside of this library: https://docs.cozy.io/en/cozy-client/api/cozy-stack-client/#getcozyurl

@Crash--
Copy link
Contributor Author

Crash-- commented Sep 3, 2023

more up to date issue ? #1381

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants