Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cozy-flags: import syntax seems to have changed #1330

Open
acezard opened this issue Aug 6, 2021 · 2 comments
Open

cozy-flags: import syntax seems to have changed #1330

acezard opened this issue Aug 6, 2021 · 2 comments
Labels
bug Something isn't working cozy-flags

Comments

@acezard
Copy link
Contributor

acezard commented Aug 6, 2021

PR for reference: cozy/cozy-notes#201

Before:

import { useFlag } from 'cozy-flags'
import flag, { FlagSwitcher } from 'cozy-flags'

After updating cozy-flags: useFlag and FlagSwitcher are undefined.

Temporary fix:

import useFlag from 'cozy-flags/dist/useFlag'
import FlagSwitcher from 'cozy-flags/dist/FlagSwitcher'
import flag from 'cozy-flags'

Here everything is defined, but the import paths are non-idiomatic.

@acezard acezard added the bug Something isn't working label Aug 6, 2021
@acezard acezard changed the title cozy-flags: import syntax seem to have changed cozy-flags: import syntax seems to have changed Aug 6, 2021
@Crash--
Copy link
Contributor

Crash-- commented Aug 6, 2021

I think this is related to #1273

@acezard
Copy link
Contributor Author

acezard commented Aug 6, 2021

I think this is related to #1273

Seems likely yes, I can't check on it right now but will do later if nobody is available in the meantime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cozy-flags
Projects
None yet
Development

No branches or pull requests

2 participants