Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hard-coding of out/ directory causes problems with multiple build methods. #91

Open
dabrahams opened this issue Aug 5, 2024 · 1 comment
Open

Hard-coding of out/ directory causes problems with multiple build methods. #91

dabrahams opened this issue Aug 5, 2024 · 1 comment

Comments

@dabrahams
Copy link

For example, I was developing from the command-line, and Sean said, “I can't get this to work with VSCode.” So I fired up VSCode to check it out. It had an entirely different build directory, but the two build methods collided over the use of the out/ directory. Hours were wasted until I figured it out.
@dabrahams
Copy link
Author

Specifically, this line in CMakePresets.json caused problems. Of course, deleting it totally borks CI.

            "binaryDir": "${sourceDir}/out/build/${presetName}",

dabrahams added a commit to stlab/adobe-contract-checks that referenced this issue Aug 5, 2024
@dabrahams
Revert "Stop forcing binaryDir"
f3de57c 
It's integral to the CI setup, even though it causes collisions with
VSCode builds. See
cpp-best-practices/cmake_template#91

This reverts commit 2e880a4.
dabrahams added a commit to stlab/adobe-contract-checks that referenced this issue Aug 5, 2024
@dabrahams
Revert "Stop forcing binaryDir"
8b1880d 
It's integral to the CI setup, even though it causes collisions with
VSCode builds. See
cpp-best-practices/cmake_template#91

This reverts commit 2e880a4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dabrahams