Skip to content
This repository has been archived by the owner on Apr 19, 2023. It is now read-only.

google benchmark support #76

Open
marcpawl opened this issue Jul 26, 2020 · 2 comments
Open

google benchmark support #76

marcpawl opened this issue Jul 26, 2020 · 2 comments

Comments

@marcpawl
Copy link

Would be nice to have Google benchmark as one of the optional dependencies

@ddalcino
Copy link
Collaborator

ddalcino commented Sep 2, 2020

I agree; a CMake flag that people can set would be a great way to encourage our users to benchmark their code.

Please note that it is trivial to add Google Benchmark as a dependency yourself, since it is hosted on Conan. Just add this line, perhaps within a conditional, to cpp_starter_project/CMakeLists.txt:

set(CONAN_EXTRA_REQUIRES ${CONAN_EXTRA_REQUIRES} benchmark/1.5.1)

An argument could be made that benchmarks should be required rather than optional, and that Google Benchmark actually belongs in cpp_starter_project/cmake/Conan.cmake right next to catch2, as an equally important part of every project. This is a matter of opinion though.

@aminya
Copy link
Contributor

aminya commented Sep 30, 2020

I prefer that we add support for Coz too. It is one of the best tools for benchmarking and profiling.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants