Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In 32-bit builds, the number of hexadecimal digits for the chunk header can be reduced to 8 #75

Open
ashtum opened this issue Mar 19, 2024 · 0 comments

Comments

@ashtum
Copy link
Collaborator

ashtum commented Mar 19, 2024

There is no practical way we could have ended up writing a chunk with a size larger than 2^32-1 on 32-bit machines because we cannot have a buffer with such a size. This presents an optimization opportunity to reduce the number of hexadecimal digits to 8 for writing the chunk header:

auto p = buf + 16;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant