Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include source file information for warnings or errors #528

Open
anarthal opened this issue Jan 3, 2024 · 4 comments · May be fixed by #704
Open

Include source file information for warnings or errors #528

anarthal opened this issue Jan 3, 2024 · 4 comments · May be fixed by #704
Assignees
@fpelliccioni
Labels
Feature Something new that it should do

Comments

@anarthal
Copy link

anarthal commented Jan 3, 2024

I'm currently getting this:

Failed to resolve reference to 'as_uint64' from 'as_uint64'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'async_start_statement_execution(const' from 'async_start_statement_execution'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'rows::operator==(const' from 'operator=='
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'get_datetime' from 'get_datetime'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'async_execute_statement' from 'async_execute_statement'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'get_uint64' from 'get_uint64'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'as_blob' from 'as_blob'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'field::operator' from 'operator='
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'field::operator' from 'operator='
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'operator=(const' from 'operator='
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'operator=(unsigned' from 'operator='
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'operator=(signed' from 'operator='
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'operator=(unsigned' from 'operator='
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'row::operator!=(const' from 'operator!='
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'async_execute' from 'async_execute'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'async_ping' from 'async_ping'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'rows::operator==(const' from 'operator=='
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'field::operator' from 'operator='
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'field(const' from 'field'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'field(unsigned' from 'field'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'field(const' from 'field'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'rows::operator!=(const' from 'operator!='
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'field(unsigned' from 'field'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'field(unsigned' from 'field'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'field::operator' from 'operator='
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'async_reset_connection' from 'async_reset_connection'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'start_statement_execution(const' from 'async_start_statement_execution'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'async_start_query' from 'async_start_query'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'operator=(const' from 'operator='
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'rows::operator!=(const' from 'operator!='
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'field(signed' from 'field'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'field_view(signed' from 'field_view'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'rows::operator' from 'rows_view'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'async_start_execution' from 'async_start_execution'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'field::operator' from 'operator='
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'field_view(signed' from 'field_view'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'as_datetime' from 'as_datetime'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'start_execution' from 'start_execution'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'async_read_resultset_head' from 'async_read_resultset_head'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'async_close_statement' from 'async_close_statement'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'operator=(signed' from 'operator='
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'get_date' from 'get_date'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'async_read_resultset_head' from 'async_read_resultset_head'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'field::operator' from 'operator='
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'field::operator' from 'operator='
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'field::operator' from 'operator='
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'as_float' from 'as_float'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'as_int64' from 'as_int64'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'operator=(unsigned' from 'operator='
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'close_statement' from 'close_statement'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'get_int64' from 'get_int64'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'as_date' from 'as_date'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'async_quit' from 'async_quit'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'read_resultset_head' from 'read_resultset_head'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'field_view(unsigned' from 'field_view'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'field::operator' from 'operator='
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'prepare_statement' from 'prepare_statement'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'execute_statement' from 'execute_statement'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'ping' from 'ping'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'reset_connection' from 'reset_connection'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'field_view(unsigned' from 'field_view'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'async_reset_connection' from 'async_reset_connection'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'async_prepare_statement' from 'async_prepare_statement'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'async_close' from 'async_close'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'row::operator!=(const' from 'operator!='
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'get_float' from 'get_float'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'field_view(signed' from 'field_view'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'async_handshake' from 'async_handshake'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'async_start_execution' from 'async_start_execution'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'async_query' from 'async_query'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'async_prepare_statement' from 'async_prepare_statement'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'start_statement_execution(const' from 'async_start_statement_execution'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'async_start_statement_execution(const' from 'async_start_statement_execution'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'close_statement' from 'close_statement'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'reset_connection' from 'reset_connection'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'field::operator' from 'operator='
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'async_ping' from 'async_ping'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'quit' from 'quit'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'start_execution' from 'start_execution'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'start_statement_execution(const' from 'start_statement_execution'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'prepare_statement' from 'prepare_statement'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'field(const' from 'field'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'row::operator' from 'row_view'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'ping' from 'ping'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'field(unsigned' from 'field'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'close' from 'close'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'field::operator' from 'operator='
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'async_close' from 'async_close'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'get_blob' from 'get_blob'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'field_view(unsigned' from 'field_view'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'get_string' from 'get_string'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'execute' from 'execute'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'query' from 'query'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'async_close_statement' from 'async_close_statement'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'operator=(signed' from 'operator='
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'start_query' from 'start_query'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'operator=(const' from 'operator='
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'read_resultset_head' from 'read_resultset_head'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'async_get_connection(diagnostics&,CompletionToken&&)' from 'async_get_connection'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'start_statement_execution(const' from 'start_statement_execution'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'field(signed' from 'field'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'as_double' from 'as_double'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'field::operator' from 'field'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'operator=(signed' from 'operator='
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'row::operator==(const' from 'operator=='
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'field::operator' from 'operator='
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'field_view(unsigned' from 'field_view'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'as_time' from 'as_time'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'operator=(unsigned' from 'operator='
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'get_time' from 'get_time'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'get_double' from 'get_double'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'field_view(signed' from 'field_view'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'row::operator==(const' from 'operator=='
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'field::operator' from 'operator='
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'field(signed' from 'field'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'close' from 'close'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'operator=(const' from 'operator='
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'field(signed' from 'field'
    Reported at src/lib/Metadata/Finalize.cpp(173)
Failed to resolve reference to 'as_string' from 'as_string'
    Reported at src/lib/Metadata/Finalize.cpp(173)

While I can track most of the failures manually, it takes unnecessary effort (specially for functions like operator==). The source file src/lib/Metadata/Finalize.cpp(173) seems an implementation detail that I should not be seeing. I'd like to know where in my code I made the mistake so I can solve it.
@sdkrystian
Copy link
Member

There is not any sort of disambiguation done when lookup for a name finds more than one symbol. Implementing this correctly will require the clang comment parser to support inline command arguments with parameter lists, as it currently considers any whitespace to be the end of an argument.

@alandefreitas alandefreitas added Bug Something isn't working Feature Something new that it should do labels May 15, 2024
@fpelliccioni
Copy link
Collaborator

@sdkrystian @alandefreitas
Do you know if clang comment parser now supports inline command arguments with parameter lists? Just want to know if this can be fixed now or if we still need to wait.

@alandefreitas alandefreitas moved this to Available in MrDocs Jun 14, 2024
@fpelliccioni
Copy link
Collaborator

@sdkrystian @alandefreitas Do you know if clang comment parser now supports inline command arguments with parameter lists? Just want to know if this can be fixed now or if we still need to wait.

@sdkrystian ping 🙏

@alandefreitas
Copy link
Collaborator

parameter lists

Is this related to parameter lists? I used to get a similar error when the documentation referred to an excluded symbol. I fixed that at some previous commit, so maybe this bug has fixed itself.

@alandefreitas alandefreitas removed the Bug Something isn't working label Oct 10, 2024
@alandefreitas alandefreitas moved this from Accepted to In progress in MrDocs Oct 10, 2024
@fpelliccioni fpelliccioni linked a pull request Oct 15, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fpelliccioni fpelliccioni

Labels
Feature Something new that it should do
Projects
MrDocs
Status: In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: source location included in warnings for unresolved references fpelliccioni/mrdocs
4 participants
@fpelliccioni @alandefreitas @sdkrystian @anarthal