Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x]: Line item's sale price can be incorrectly calculated when a discount's stop processing is on #3928

Closed
nfourtythree opened this issue Mar 11, 2025 · 2 comments
Assignees
Labels
bug commerce4 Issues related to Commerce v4 Craft Commerce

Comments

@nfourtythree
Copy link
Contributor

What happened?

Description

When having a discount setup as shown below, an incorrect sale price is calculated. Even though the first matches and is set to "stop processing" the "ignore sales" from the second discount is still being taken into consideration.

Image

Craft CMS version

4.x

Craft Commerce version

4.x

PHP version

No response

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

No response

@nfourtythree nfourtythree added bug commerce4 Issues related to Commerce v4 Craft Commerce labels Mar 11, 2025
@nfourtythree nfourtythree self-assigned this Mar 11, 2025
nfourtythree added a commit that referenced this issue Mar 12, 2025
…sale-price-can-be-incorrectly-calculated-when

fix #3928 line item sale price calculation and discount “stop processing”
@nfourtythree
Copy link
Contributor Author

A fix for this has been pushed to both 4.x and 5.x versions of Commerce and will be included in the next releases.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug commerce4 Issues related to Commerce v4 Craft Commerce
Projects
None yet
Development

No branches or pull requests

1 participant