Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date fields in matrixblocks are incorrectly compared spawns new revisions #1403

Closed
jeffreyzant opened this issue Jan 19, 2024 · 1 comment
Closed
Assignees
Labels

Comments

@jeffreyzant
Copy link
Contributor

Description

The _recursiveCompare method in the DataHelper does not handle date fields correctly. Craft return dates as "Y-m-d H:i:s", while feed-me compares them to a Carbon object which results in a mismatch. This causes feed-me to resave the post spawning a new revision even though there are no content changes.

The root method compareElementContent does handle dates correctly.

I'll submit a PR following this issue to resolve it.

Additional info

  • Craft version: 4.5.13
  • PHP version: 8.3.0
  • Plugins & versions: 5.3.0
@angrybrad
Copy link
Member

Merged PR and this will be included in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants