Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add audio datasources #6535 #1810

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alhambrav
Copy link
Member

Ticket reference or full description of what's in the PR

Add audio datasources craftercms/craftercms#6535

@sumerjabri sumerjabri requested a review from rart April 5, 2024 18:06
@sumerjabri
Copy link
Member

@rart bump

1 similar comment
@sumerjabri
Copy link
Member

@rart bump

Copy link
Member

@rart rart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content seems fine.

Now, I noticed a few things but I realise it is a bigger matter, as all of the previously existing data source pages share the same characteristics:

  • The "Data Source Basics" section are shown in a table with each property as a row, versus the "Properties" section is
    • jammed in a single cell
    • using - as bullets instead of an actual bulleted list, which isn't great for accessibility or even for aesthetics.
      • the properties are less readable without them having their own column or having some bolding in the single-cell-listing.
  • The screenshot is not useful, it just shows the same as the textual descriptions and the 2 column layout isn't appealing.

If deemed worthy, perhaps you can create a ticket to address this matter as a whole.

Suggestions


Option 1:

The distinction between "Data source basics" and "Properties" is not meaningful, so put it all on the same table:

Property Description
Name Name of variable to store the final result in.
Repository Path Path where to store the new audio uploaded from desktop.
Use Search Enable or disable searching for audios in the repository.

Option 2:

If keeping them separate is desired, use consistent format for both:

"Data Source Basics" Section

Property Description
Name Name of variable to store the final result in.

"Properties" Section

Property Description
Repository Path Path where to store the new audio uploaded from desktop.
Use Search Enable or disable searching for audios in the repository.

Option 2.1:

Use a single table with row headings

Property Description
Basics Section Name Name of variable to store the final result in.
Properties Section Repository Path Path where to store the new audio uploaded from desktop.
Use Search Enable or disable searching for audios in the repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants