Replies: 1 comment
-
The best way to request a feature is to fix it yourself as you did 😉 and then create a pull request. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi Experts,
I would like to create a feature request. Is there a way to create a feature request instead of opening as an issue. Issue seems to give impression that some bug is reported.
Would like to request following feature
Allow to set recv_pin dynamically by a set function. Currently it is done at the time of constructor only. For my own implementation I added following in IRrecv.cpp
void IRrecv::setPin(const uint16_t recvpin) { params.recvpin = recvpin; }
and declaration in IRrecv.h
void setPin(const uint16_t recvpin);
It allows me to dynamically change receiver pin as I have 2 receiver in my project 38KHz and 56KHz after realizing that some ACs are Remotes are not detected properly with 38KHz. Have one Hitachi AC remote that detects correct protocol with 56KHz but not with 38KHz .
I could create 2 objects one with 38KHz recv pin and one with 56KHz recv pin but that is unnecessary waste of resources. So I added a function in IRrecv which works fine. However I hate to add custom changes in the libraries and so would like to create a feature request. What is the best way to request such simple feature?
Beta Was this translation helpful? Give feedback.
All reactions