Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Zeroize #1

Open
kevaundray opened this issue May 30, 2020 · 4 comments
Open

Add Zeroize #1

kevaundray opened this issue May 30, 2020 · 4 comments

Comments

@kevaundray
Copy link
Contributor

No description provided.

@anonion0
Copy link
Contributor

I added Zeroize support, but it first requires support for it in the ed448-goldilocks crate as well: PR

Should you decide to merge that and release a new ed448-goldilocks crate version, I'll make a PR here.

@kevaundray
Copy link
Contributor Author

Thank you very much for this. I've merged your other PR and have released a new version 0.8.3 with the changes to crates.io

@anonion0
Copy link
Contributor

anonion0 commented Feb 3, 2022

w.r.t. the zeroing of stack variables containing secret data (e.g. during curve point multiplication): I took a quick glance at the x25519-dalek and curve25519-dalek crates to see how they handle it. It seems as they currently don't do anything of the sort.

Some further work is probably needed.

@kevaundray
Copy link
Contributor Author

Oh right, I believe there was an issue where it was discussed, but I cannot find it right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anonion0 @kevaundray