Commit fb45cbc
committed
test: Remove require.NoError() which will always fail
While testing ignition changes, `make test-unit` fails more often than
not because of an error returned by `startIgnitionProvisionerServerInternal`
I don’t know if this is triggered by my changes, or by the fact that
before df03cab, this test was seldomly run.
However, it’s incorrect to assert with `require.NoError(t, err)` after
calling `startIgnitionProvisionerServerInternal` as this ends with
`return srv.Serve(listener)` which is documented as always failing:
https://pkg.go.dev/net/http#Server.Serve
> Serve always returns a non-nil error
Signed-off-by: Christophe Fergeau <[email protected]>1 parent 81b71ee commit fb45cbc
1 file changed
+1
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
33 | | - | |
| 32 | + | |
34 | 33 | | |
35 | 34 | | |
36 | 35 | | |
| |||
0 commit comments