Needs tests

[julie777]

Feel free to raise an issue for any of the following:

• Feature request

There are no tests in the repository

[jnichols0]

The tests are in the hitch/story directory, you can read about running them here https://hitchdev.com/approach/contributing/

[julie777]

The tests are in the hitch/story directory, you can read about running them here https://hitchdev.com/approach/contributing/

Thanks. I never thought of looking in a different repo for them.

I am going to need to study hitchstory. I have substantial experience using behave for BDD. I am curious to see the changes.

[mtelka]

Is there a simple way how to run tests for this project? Thank you.

[crdoconnor]

Yes, apologies I let the original instructions get out of date. I'll update them tonight.

…

On Fri, 21 Apr 2023, 17:22 Marcel Telka, ***@***.***> wrote: Is there a simple way how to run tests for this project? Thank you. — Reply to this email directly, view it on GitHub <#168 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABOJKNOASFRZBENVGCAIK43XCKX3TANCNFSM5PK4XZOQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[crdoconnor]

The updated instructions are visible here: https://hitchdev.com/approach/contributing/

[mtelka]

Thank you. That looks easy. If I read the URL properly just ./key.sh make followed by ./key.sh regression should be run to test strictyaml. If that's the case then I think you could create simple tox.ini file to have both commands run by tox which is currently the preferred way how to run tests uniformly for most Python projects.

[crdoconnor]

As I understand it tox is just a different way of creating virtual environments, etc. to run tests in. This is something the code run by key.sh already does. It also containerizes the running code to ensure for greater consistency, which tox can't and doesn't do.

[mtelka]

Not only that. tox could be used also with current environment (as opposed to virtualized or containerized env) using the tox-current-env plugin. This is exactly what is needed for downstream packagers like me. I'm packaging strictyaml (and many other Python projects) for OpenIndiana and we need to run tests in current environment to make sure the built package will work as expected and designed.

[crdoconnor]

ah, fair enough. if I wrote a separate script that runs the tests in the environment the script is run in would that suffice?

…

On Fri, 21 Apr 2023, 22:34 Marcel Telka, ***@***.***> wrote: Not only that. tox could be used also with current environment (as opposed to virtualized or containerized env) using the tox-current-env plugin. This is exactly what is needed for downstream packagers like me. I'm packaging strictyaml (and many other Python projects) for OpenIndiana and we need to run tests in current environment to make sure the built package will work as expected and designed. — Reply to this email directly, view it on GitHub <#168 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABOJKNPV5UY5EV3CKBRBSN3XCL4MRANCNFSM5PK4XZOQ> . You are receiving this because you commented.Message ID: ***@***.***>

[mtelka]

if I wrote a separate script that runs the tests in the environment the script is run in would that suffice?

Sounds reasonable.