[Bug] Repo url of open data handbook is compromised

[Xaid-vfx]

Description

Due to some previous commits, the repository button of open data handbook resource is not displayed. I think that the commit responsible for this bug is this.

The repository url that was compromised : Link

Reproduction

1. Go to https://resources.creativecommons.org/open-data-handbook/
2. See the download button.

Expectation

This bug can be fixed by adding the Repository button back.
If this was intentional, the repourl from opendatahandbook.html can be removed to resolve this bug.

Screenshots

[Lakshay-Pruthi]

Thanks @Xaid-vfx for letting me work on this but first we need to know the reason of removal of code in resource.html from @Keerthivardhan1 then any further steps can be taken.

[pushkar707]

Hi @Xaid-vfx, can you please assign this issue to me? I will add back the repo URL in the resource.html to resolve the issue

[Xaid-vfx]

Hey @pushkar707, currently this issue is not approved and @Lakshay-Pruthi would be working on it on approval. You guys can discuss or collaborate on this one.

@Lakshay-Pruthi I think the reason for removal of code would just be that most of the repository links were not working which led to compromise of the link that was working. A good solution would be to:

1. keep the repository button code in resource.html
2. remove the non-working repo urls from resource files.
3. Arrange the CSS for both cases when repo url is present or not( a flexbox would be good)

I think we need input from @possumbilities on this.

[pushkar707]

okay @Xaid-vfx. I am fine with working with @Lakshay-Pruthi, if he might want any help

[Keerthivardhan1]

@Xaid-vfx under the guidance of @possumbilities I have removed all the repository links which are broken.
I think this issue is occurring with only --> open data hand book page.

[Keerthivardhan1]

@Xaid-vfx we should not include the repository button again.
for more information feel free to look #11

[Xaid-vfx]

Hey @Keerthivardhan1 ,
I went through the issue #11 and what has come to my understanding is that you were supposed to remove all broken links.
The repository link of open data handbook was not broken and yet it is not displayed because you removed the repository button code entirely.
Here's the link to open data handbook repo: https://github.com/okfn/opendatahandbook

Now coming to issue:
This issue is occurring because there is a repourl present is open-data-handbook.html, due to which the width of download button is set to 440px. See below:

You can remove the repourl from open-data-handbook.html and the issue will be resolved.

Now coming to the expected behaviour:

• If the repository button was supposed to be removed even if the repository link was working, then your changes in resource.html are fine, but you were also supposed to remove the working repourl from open-data-handbook.html.

• If only the broken links were supposed to be removed then you were not supposed to remove the repository button for open data handbook resource, as its repository link was working.

I believe the issue was the latter one which is removing links not button. Also, its not a CSS issue, because it were all other resources should display the same behavior as we have common CSS for all resources. Checkout the below resource it works fine:

Hope this explains the issue.

[Keerthivardhan1]

I am very sorry for the inconvenience. @Xaid-vfx what you said is correct.
I missed it.
If you want any help I am very happy to help you out.

[Lakshay-Pruthi]

I don't think the repository button was supposed to removed but if it was then the whole repo url code should be removed.

[Lakshay-Pruthi]

This issue is dependent on #82 . First that should be resolved then any steps regarding this can be taken.

[Keerthivardhan1]

According to me one of the best solution is .
there should be repository button in resource.html
but it should be like
if ( a resource page has repository link ) :
display it
else :
ignore the repo button

[Xaid-vfx]

I am very sorry for the inconvenience. @Xaid-vfx what you said is correct. I missed it. If you want any help I am very happy to help you out.

@Keerthivardhan1 you don't have to be sorry :)

@Lakshay-Pruthi as @Keerthivardhan1 mentioned, the issue can simply be solved by rendering the repository button only when there's a repourl present in its resource file.

[Lakshay-Pruthi]

@Xaid-vfx As I earlier said, First issue #82 should be resolved because if we add a visit button to every resource then there is no need of repo button.