Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include some more infos for each implementation #51

Closed
2 of 3 tasks
harrel56 opened this issue Nov 12, 2023 · 2 comments
Closed
2 of 3 tasks

Include some more infos for each implementation #51

harrel56 opened this issue Nov 12, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@harrel56
Copy link
Contributor

harrel56 commented Nov 12, 2023

I feel like there might be a few more metric which could be taken into account when choosing an implementation:

  • raw size of jar (KBs)
  • required dependencies (it would be great the include overall package size with its dependencies but I guess that's not so easy)
  • compatible java version - no idea if there are some that require something newer than java 8
  • where the lib is stored - maven, jitpack
  • if it support format assertions - probably just looking on optional tests output would be enough

Let me know if these metrics sound sensible to you. Also I could help you out with it if you want to

Tasks

  1. enhancement
    big-andy-coates
  2. enhancement
  3. enhancement
    big-andy-coates
@harrel56 harrel56 added the enhancement New feature or request label Nov 12, 2023
@big-andy-coates
Copy link
Member

Thanks @harrel56

I've already a task for picking up the implementation's version number. I've created other tasks for some of the others. Not convinced what the effort to reward ratio is on this though.

  • where the lib is stored - maven, jitpack

This can be found out by anyone following the link a validators main site / GitHub repo.

I don't think duplicating the info here adds value, only a chance it will get out of data.

  • if it support format assertions

Format assertions is only one of many optional features - as you say, this is covered by the functional tests, and also by looking at the implementations documentations.

@big-andy-coates
Copy link
Member

I'm going to close this, as the sub tasks now track the work. Thanks @harrel56 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants