Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace name property by simple attribute #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace name property by simple attribute #65

wants to merge 1 commit into from

Conversation

huard
Copy link
Collaborator

@huard huard commented Oct 16, 2024

Fix #63

mishaschwartz
mishaschwartz approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@mishaschwartz mishaschwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Is there a reason that the prefix and the name were linked before? Is there any value in trying to enforce that the prefix and the name are the same?

@huard
Copy link
Collaborator Author

huard commented Oct 16, 2024

I suspect not having this consistency might break some of the STAC stuff. Note that this consistency is ensured in the cordex_extension branch. I'll be able to port the changes to CMIP6 once we agree on the framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mishaschwartz mishaschwartz mishaschwartz approved these changes

@fmigneault fmigneault Awaiting requested review from fmigneault fmigneault is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pystac extension not handling well name property
2 participants
@huard @mishaschwartz