Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] minOccurs/maxOccurs representation #263

Closed
fmigneault opened this issue Jun 10, 2021 · 0 comments · Fixed by #272
Closed

[Feature] minOccurs/maxOccurs representation #263

fmigneault opened this issue Jun 10, 2021 · 0 comments · Fixed by #272
Assignees
Labels
triage/conformance Issue related to fixing/ensuring compliance to specifications. triage/feature New requested feature.

Comments

@fmigneault
Copy link
Collaborator

As per https://github.com/opengeospatial/ogcapi-processes/blob/master/core/openapi/schemas/inputDescription.yaml

minOccurs should always be an int
maxOccurs should always be an int or explicitly "unbounded"

Currently, the values are always returned as string.

We must return the process description according to the reference schema.
Because of pre-existing/deployed/remote processes, the conversion should be done in place such that values stored in db or read from remote instance are converted to int as needed before returning the process description.

During deployment, current behaviour that handles both numerical str or int should remain valid such that it doesn't break existing request contents. Future deployments should transparently convert the items as applicable.

@fmigneault fmigneault added the triage/feature New requested feature. label Jun 10, 2021
@fmigneault fmigneault added this to the OGC-API Conformances milestone Jun 10, 2021
@fmigneault fmigneault added the triage/conformance Issue related to fixing/ensuring compliance to specifications. label Jun 10, 2021
@trapsidanadir trapsidanadir linked a pull request Jul 5, 2021 that will close this issue
fmigneault added a commit that referenced this issue Jul 7, 2021
 Fixed  representation according to ogcapi (fixes #263)
fmigneault added a commit that referenced this issue Aug 24, 2021
fmigneault added a commit that referenced this issue Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/conformance Issue related to fixing/ensuring compliance to specifications. triage/feature New requested feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants