Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed representation according to ogcapi (fixes #263) #272

Merged
merged 6 commits into from
Jul 7, 2021
Merged

Fixed representation according to ogcapi (fixes #263) #272

merged 6 commits into from
Jul 7, 2021

Conversation

trapsidanadir
Copy link
Contributor

@trapsidanadir trapsidanadir commented Jul 5, 2021 •
edited
Loading

Fixing representation of maxoccurs and minoccurs according to ogcapi (fixes #263).

@trapsidanadir trapsidanadir added this to the OGC-API Conformances milestone Jul 5, 2021
@trapsidanadir trapsidanadir self-assigned this Jul 5, 2021
@github-actions github-actions bot added ci/tests Tests of the package and features feature/db Related to database or datatype manipulation. ci/doc Issue related to documentation of the package labels Jul 5, 2021
@codecov
Copy link

codecov bot commented Jul 5, 2021 •
edited
Loading

Codecov Report

Merging #272 (ee8a697) into master (d22419a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #272      +/-   ##
==========================================
+ Coverage   71.97%   71.98%   +0.01%     
==========================================
  Files          61       61              
  Lines        9384     9389       +5     
  Branches     1411     1413       +2     
==========================================
+ Hits         6754     6759       +5     
  Misses       2237     2237              
  Partials      393      393
Impacted Files Coverage Δ
weaver/datatype.py 62.17% <100.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d22419a...ee8a697. Read the comment docs.

@trapsidanadir trapsidanadir linked an issue Jul 5, 2021 that may be closed by this pull request
[Feature] minOccurs/maxOccurs representation #263
Closed
@trapsidanadir trapsidanadir changed the title Fixed representation according to ogcapi (fixes #237) Fixed representation according to ogcapi (fixes #263) Jul 5, 2021
fmigneault
fmigneault requested changes Jul 5, 2021
View reviewed changes
Copy link
Collaborator

@fmigneault fmigneault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update the changelog with description and link to fixed issue.

weaver/datatype.py Outdated Show resolved Hide resolved
fmigneault
fmigneault requested changes Jul 6, 2021
View reviewed changes
CHANGES.rst Outdated Show resolved Hide resolved
weaver/datatype.py Outdated Show resolved Hide resolved
weaver/datatype.py Outdated Show resolved Hide resolved
fmigneault
fmigneault reviewed Jul 7, 2021
View reviewed changes
weaver/datatype.py Outdated Show resolved Hide resolved
@fmigneault fmigneault merged commit 65490d1 into master Jul 7, 2021
@fmigneault fmigneault deleted the minmax-occurs-rep branch July 7, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmigneault fmigneault fmigneault approved these changes

Assignees

@trapsidanadir trapsidanadir

Labels
ci/doc Issue related to documentation of the package ci/tests Tests of the package and features feature/db Related to database or datatype manipulation.
Projects
None yet
Milestone
OGC-API Conformances
Development

Successfully merging this pull request may close these issues.

[Feature] minOccurs/maxOccurs representation
2 participants
@trapsidanadir @fmigneault