Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CLI package operation + support CWL package retrieval for provider process #562

Merged
merged 5 commits into from
Sep 18, 2023

Conversation

fmigneault
Copy link
Collaborator

@fmigneault fmigneault commented Sep 15, 2023

Changes

  • Add GET /providers/{provider_id}/processes/{process_id}/package endpoint that allows retrieval of the CWL
    Application Package definition generated for the specific Provider's Process definition.
  • Add CLI package operation to request the remote Provider or local Process CWL Application Package.
  • Add CLI output reporting of performed HTTP requests details when using the --debug/-d option.
  • Modify default behavior of visibility field (under processDescription or processDescription.process)
    to employ the expected functionality by native OGC API - Processes clients that do not support this option
    (i.e.: public by default), and to align resolution strategy with deployments by direct CWL payload which do not
    include this feature either. A Process deployment that desires to employ this feature (visibility: private) will
    have to provide the value explicitly, or update the deployed Process definition afterwards with the relevant
    PUT request. Since public will now be used by default, the CLI will not automatically inject the value
    in the payload anymore when omitted.

Fixes

  • Fix links listing duplicated in response from Process deployment.
    Links will only be listed within the returned processSummary to respect the OGC API - Processes schema.
  • Fix CLI not removing embedded links in processSummary from deploy operation response
    when -nL/--no-links option is specified.

@fmigneault fmigneault self-assigned this Sep 15, 2023
@github-actions github-actions bot added ci/doc Issue related to documentation of the package feature/cli Issues or features related to CLI operations. feature/oas Issues related to OpenAPI specifications. process/wps3 Issue related to WPS 3.x (REST-JSON) processes support feature/providers Issue related to providers convertion to WPS-REST processes. labels Sep 15, 2023
@github-actions github-actions bot added ci/tests Tests of the package and features feature/db Related to database or datatype manipulation. labels Sep 16, 2023
perronld
perronld previously approved these changes Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #562 (d1f961a) into master (34debdc) will increase coverage by 0.01%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##           master     #562      +/-   ##
==========================================
+ Coverage   84.46%   84.47%   +0.01%     
==========================================
  Files          79       79              
  Lines       17704    17732      +28     
  Branches     2685     2688       +3     
==========================================
+ Hits        14953    14979      +26     
- Misses       2022     2024       +2     
  Partials      729      729              
Files Changed Coverage Δ
weaver/wps_restapi/providers/providers.py 84.72% <80.00%> (-0.79%) ⬇️
weaver/cli.py 85.83% <95.45%> (+0.23%) ⬆️
weaver/datatype.py 78.81% <100.00%> (ø)
weaver/processes/utils.py 79.85% <100.00%> (+0.07%) ⬆️
weaver/wps_restapi/providers/__init__.py 100.00% <100.00%> (ø)
weaver/wps_restapi/swagger_definitions.py 99.82% <100.00%> (+<0.01%) ⬆️

@fmigneault fmigneault merged commit b99e39b into master Sep 18, 2023
46 of 47 checks passed
@fmigneault fmigneault deleted the cli-provider-package branch September 18, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/doc Issue related to documentation of the package ci/tests Tests of the package and features feature/cli Issues or features related to CLI operations. feature/db Related to database or datatype manipulation. feature/oas Issues related to OpenAPI specifications. feature/providers Issue related to providers convertion to WPS-REST processes. process/wps3 Issue related to WPS 3.x (REST-JSON) processes support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants