-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix notification email encrypt/decrypt implementation #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmigneault
added
triage/security
Issue related to authorization or general security vulnerability
feature/job
Issues related to job execution, reporting and logging.
labels
Oct 6, 2023
github-actions
bot
added
feature/db
Related to database or datatype manipulation.
ci/doc
Issue related to documentation of the package
ci/tests
Tests of the package and features
labels
Oct 6, 2023
fmigneault
changed the title
[wip] fix notification email encrypt/decrypt implementation
fix notification email encrypt/decrypt implementation
Oct 6, 2023
…by aggreation pipeline with non-deterministic decrypt values
github-actions
bot
added
feature/oas
Issues related to OpenAPI specifications.
process/wps3
Issue related to WPS 3.x (REST-JSON) processes support
labels
Oct 6, 2023
Codecov Report
@@ Coverage Diff @@
## master #571 +/- ##
==========================================
+ Coverage 84.55% 84.71% +0.15%
==========================================
Files 79 79
Lines 17793 17828 +35
Branches 2709 2708 -1
==========================================
+ Hits 15045 15103 +58
+ Misses 2020 1992 -28
- Partials 728 733 +5
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci/doc
Issue related to documentation of the package
ci/tests
Tests of the package and features
feature/db
Related to database or datatype manipulation.
feature/job
Issues related to job execution, reporting and logging.
feature/oas
Issues related to OpenAPI specifications.
process/wps3
Issue related to WPS 3.x (REST-JSON) processes support
triage/security
Issue related to authorization or general security vulnerability
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Job
to easily retrieve its various URLs.weaver.wps_email_notify_timeout
setting (default 10s) to avoid SMTP server deadlock on failing connection.encrypt_email
function to use an alternate strategy allowingdecrypt_email
onJob
completed.notification_email
fromGET /jobs
query parameters.Due to the nature of the encryption strategy, this cannot be supported anymore.
Fixes
Job
submitted with anotification_email
not reversible from its encrypted value to retrieve the originalemail on
Job
completion to send the notification (fixes Weaver tries to send e-mail to hashed notification_email #568).${logs}
.Instead, the new utility methods
job.[...]_url
should be used to retrieve relevant locations.