Just a question

[YamadaHideki]

Hello. Why you used this in the DetectCodePage?
LSet lt = fbt

[cristianbuse]

Hi, just because I needed to convert the 4 bytes into a DWORD. I could have done this in a few other ways, obviously.
I did not do it via math operations because that's the slowest option. I did not do it via additional memory 'accessors' because I did not want to add additional stuff to the stack. And of course, a RtlMoveMemory is out of the question for VBA.

Is there a reason why you're asking, or just from curiosity?

[YamadaHideki]

This is a question because i saw in the microsoft documentation next sentenses
Using LSet to copy a variable of one user-defined type into a variable of a different user-defined type is not recommended. Copying data of one data type into space reserved for a different data type can cause unpredictable results.

[cristianbuse]

Oh that. 😆 Yeah, I wouldn't worry about that in this simple scenario. Unpredictable results can happen with more complex UDTs (with nested structures containing strings and arrays) not with 4 adjacent bytes.

That being said, I might replace this method entirely with using a ByteAccessor as I remember quickly doing this one to move over to some other parts of the module.

[YamadaHideki]

Why you used strange name variables here

Public Enum JsonPageCode
    jpCodeAutoDetect = -1
    [_jpcNone] = 0
    jpCodeUTF8 = 65001
    jpCodeUTF16LE = 1200
    jpCodeUTF16BE = 1201
    jpCodeUTF32LE = 12000
    jpCodeUTF32BE = 12001
    [_jpcCount] = 5
End Enum

like [_jpcNone] and [_jpcCount]

[cristianbuse]

The _ hides them from intellisense and because of the _ the square brackets are mandatory. Moreover, I used the jp prefix to avoid clashes with other enums that users might have in their projects.

[YamadaHideki]

Cool. I didn't know about the underscore

[YamadaHideki]

Since we have renamed the Dictionary class to FastDictionary, the Serialize method will not work out of the box, because the check is written based on the fact that Scripting.Dictionary and FastDictionary vartype defines the same. Is it possible to make something more convenient to work with different naming of the dictionary class, because with the new version we will have to rewrite part of the code in the FastJson class again.

isDict = (TypeOf vars.arr(0) Is Dictionary)

[YamadaHideki]

What I meant was that I would need to complete the code as just Find and Replace would won't help. For Scripting.Dictionary you need to write new code, for example
I am obliged to declare dict as an object and do such a check

Dim dict        As Object
Dim isDict      As Boolean
'
isDict = (TypeOf vars.arr(0) Is Scripting.Dictionary) Or (TypeOf vars.arr(0) Is FastDictionary)

instead of

Dim dict        As Dictionary
isDict = (TypeOf vars.arr(0) Is Dictionary)

[cristianbuse]

If I implement isDict = (TypeOf vars.arr(0) Is Scripting.Dictionary) then anyone using this repository will need a reference to Scripting Runtime which I did not want to enforce.

Hmm, thinking about it now, I would not mind if Scripting.Dictionary is called via late-binding. This would only happen if the Dictionary is not scripting already. I.e. check against Dictionary (FastDictionary in your case) via early-binding and if not the correct interface then try scripting via late-binding. Hope it makes sense.

[sancarn]

@cristianbuse or if you don't want that time penalty, use compiler flags for toggle-able late vs early binding

[cristianbuse]

@YamadaHideki

This should solve your issue: Added late-binding support for Scripting.Dictionary in case it is not the main Dictionary

@sancarn The commit I just pushed solves this issue. I don't mind if Scripting is called via late-binding if the main dictionary is something else. My goal is that users don't use Scripting anyway. Plus, if they only use Scripting then it would be early-binded by default.

[YamadaHideki]

@cristianbuse Thank you, i will test it.

[YamadaHideki]

It would be great to see an IsJson function

[cristianbuse]

Ok. To get around the compilation error, you must make the call indirect. For example, you can try to call a method in the remote project via Application.Run, and the method would return a json string. If Application.Run fails, you can trap the error via error handling at runtime.

[YamadaHideki]

The problem is that when the AutoExec macro is triggered, the code of other libraries is unavailable, because it is executed even before connecting other libraries.

[cristianbuse]

Understood. You need to delay execution until after the libraries get connected.

For example:

• your AutoExec macro writes some value to the registry using SaveSetting
• library connects
• library runs it's own AutoExec and reads registry via GetSetting
• library triggers a macro in the original project using the registry values (Application.Run maybe?)

This is just an idea but you can of course try different approaches, like a timer or some kind of event.

[YamadaHideki]

@cristianbuse Is there any difference in parsing speed for string or byte array parsing?

[cristianbuse]

Copying a string into an array of bytes or viceversa is quite fast. For small data there is no difference. The speed difference is only felt for large data but even that is not important. More importantly is that we avoid unnecessary copies that might fill up the stack.

[YamadaHideki]

Have you tried passing a missing variable to the serializer? I have Error 4 like a result.

[cristianbuse]

Will update tomorrow

[YamadaHideki]

Thank you.

[YamadaHideki]

Founded error. Trying to reproduce

[YamadaHideki]

I can't reproduce it, it works only on my project. The point is that here .ub = bounds.sa.rgsabound0.cElements - 1 returns -1, because bounds.sa.rgsabound0.cElements = 0, respectively, here .ub = bounds.rgsabound(.ub).cElements - 1 an error already occurs.

[cristianbuse]

v1.0.4 converts Missing to null. If a key is Missing then it either skips it (default) or converts it to "Missing" if forceKeysToText. Thanks