Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter flannel::etcd_endpoints has faulty documentation #10

Open
ananace opened this issue Apr 7, 2017 · 0 comments
Open

Parameter flannel::etcd_endpoints has faulty documentation #10

ananace opened this issue Apr 7, 2017 · 0 comments

Comments

@ananace
Copy link

ananace commented Apr 7, 2017

The documentation states;

# [*etcd_endpoints*]
#   a comma-delimited list of etcd endpoints.
#   Type: Array or String
#   Defaults to http://127.0.0.1:4001

In etcd_key.pp though, it's expected to always be an array;

  etcd_key { "${::flannel::etcd_prefix}/config":
    value     => template('flannel/etcd_network_definition.erb'),
    peers     => join($::flannel::etcd_endpoints, ','), # This line
    cert_file => $::flannel::etcd_certfile,

On Puppet 4 at least, this is a compile error in case you provide the etcd_endpoints as a comma-separated string;

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Function Call, join(): Requires array to work with at /etc/puppetlabs/code/environments/devel/modules/flannel/manifests/etcd_key.pp:45:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant