beforeValidate() may cause problem when change status.

[sitawit]

Issue

If you have other statuses as

• "" (an empty string)
• 0 (0 as an integer)
• 0.0 (0 as a float)
• "0" (0 as a string)
• FALSE

It will become a "default" status when you try to change status.

The Cause

The following function tries to set an empty status to be a "default" status.

    public function beforeValidate($event)
    {
        parent::beforeValidate($event);
        if ($this->owner->hasAttribute($this->statusAttribute) && empty($this->owner->{$this->statusAttribute})) {
            $this->owner->{$this->statusAttribute} = $this->defaultStatus;
        }
    }

So any value that makes empty() return true will cause the status become a "default".
However, this may not a big error but it could cause the confusion.

Possible solutions

• Update read me file to warn people that don't use those value for other statuses than the default one.

or

• Update the function to check the value properly