Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal options "remote" does not work #116

Open
mitrii opened this issue Aug 19, 2013 · 3 comments
Open

Modal options "remote" does not work #116

mitrii opened this issue Aug 19, 2013 · 3 comments
Assignees
Labels

Comments

@mitrii
Copy link

mitrii commented Aug 19, 2013

I think, missed 3rd parameter in function TbArray::popValue on line 160

@crisu83
Copy link
Owner

crisu83 commented Sep 1, 2013

Please explain this issue and I'll see what I can do.

@mitrii
Copy link
Author

mitrii commented Sep 3, 2013

For example:

    <?php $this->widget('bootstrap.widgets.TbModal', array(
        'id' => 'myModal',
        'header' => 'Modal Heading',
        'remote' => 'http://example.com',
        'footer' => array(
            TbHtml::button('Save Changes', array('data-dismiss' => 'modal', 'color' => TbHtml::BUTTON_COLOR_PRIMARY)),
            TbHtml::button('Close', array('data-dismiss' => 'modal')),
        ),
    )); ?>

Any value in option "remote" ignored, because in line 160 of TbModal.php missed 3rd parameter:

if ($remote = TbArray::popValue('remote', $this->options)) {

Must be:

if ($remote = TbArray::popValue('remote', $this->options, $this->remote)) {

@crisu83
Copy link
Owner

crisu83 commented Oct 28, 2013

I will fix this when add the new version of the modal widget. #148

@ghost ghost assigned crisu83 Oct 28, 2013
@crisu83 crisu83 assigned crisu83 and unassigned crisu83 Feb 11, 2015
@crisu83 crisu83 removed this from the 1.3.0 milestone Apr 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants