fix broken rule, set Angular/Typescript as optionalPeerDeps

Author: Fuzzball24816

.eslintrc.js

@@ -2,7 +2,7 @@
 
 module.exports = {
   root: true,
-  extends: ['eslint:recommended', 'plugin:eslint-plugin/recommended', 'plugin:node/recommended'],
+  extends: ['eslint:recommended', 'plugin:eslint-plugin/recommended', 'plugin:n/recommended'],
   env: {
     node: true,
   },

CHANGELOG.md

@@ -7,6 +7,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 Please see [the README](./README.md) for details of added rules.
 
+## 5.4.0
+
+- no-indexed-access-on-enums - fix missing import that caused eslint to crash when using this rule
+- Mark Angular and Typescript peerDependencies as optional
+- Switch from eslint-plugin-node to eslint-plugin-n
+  - eslint-plugin-node is no no longer maintained, eslint-plugin-n is a fork
+- no-spreading-accumulators - pass error message in to remove eslint-plugin/prefer-message-ids lint error
+
 ## [5.3.0]
 
 - Disable the rule `no-call-expression` from `@angular-eslint/eslint-plugin-template` to allow using [signals](https://angular.dev/guide/signals)
@@ -34,9 +42,9 @@ Please see [the README](./README.md) for details of added rules.
 ### Changed
 
 - Removal of the rules `deny-constructor-di` and `import-inject-object` from `@rdlabo/eslint-plugin-rules` because the auto-fix has too many issues:
-  - It applies on irrelevant places cf https://github.com/rdlabo-team/eslint-plugin-rules/issues/1#issuecomment-1980955010
-  - It gets lost with access modifiers cf https://github.com/rdlabo-team/eslint-plugin-rules/issues/4
-  - It generates broken code cf https://github.com/rdlabo-team/eslint-plugin-rules/issues/5
+  - It applies on irrelevant places cf <https://github.com/rdlabo-team/eslint-plugin-rules/issues/1#issuecomment-1980955010>
+  - It gets lost with access modifiers cf <https://github.com/rdlabo-team/eslint-plugin-rules/issues/4>
+  - It generates broken code cf <https://github.com/rdlabo-team/eslint-plugin-rules/issues/5>
 - Removal of deprecated configurations
 
 ## [5.1.0]
@@ -59,7 +67,7 @@ Please see [the README](./README.md) for details of added rules.
 
 ### Changed
 
-- Rule `no-indexed-access-on-enums` disabled due to the bug https://github.com/criteo/eslint-plugin-criteo/issues/30
+- Rule `no-indexed-access-on-enums` disabled due to the bug <https://github.com/criteo/eslint-plugin-criteo/issues/30>
 - Rule `ngx-component-display` now ignores components matching `^.*(?:Dialog|Modal)Component$` (previously, only `^.*DialogComponent$` were ignored)
 
 ## [4.12.0]
@@ -165,7 +173,7 @@ Please see [the README](./README.md) for details of added rules.
 ### Changed
 
 - [BREAKING] Upgrade Angular plugins to version 13 for compatibility with Angular 13
-- [BREAKING] Move dependent plugins to peerDependencies so that they appear in the root node_modules (https://github.com/criteo/eslint-plugin-criteo/issues/15)
+- [BREAKING] Move dependent plugins to peerDependencies so that they appear in the root node_modules (<https://github.com/criteo/eslint-plugin-criteo/issues/15>)
 - [BREAKING] Update `engines` field in package.json to only allow npm versions >= 7
 
 ## [3.2.1]

lib/rules/filename-match-export.js

@@ -4,7 +4,7 @@
  */
 'use strict';
 
-const path = require('path');
+const path = require('node:path');
 
 const clean = (value) => (value ?? '').toLowerCase().replace(/[^a-z0-9]+/g, '');
 

lib/rules/filename.js

@@ -4,7 +4,7 @@
  */
 'use strict';
 
-const path = require('path');
+const path = require('node:path');
 const {
   COMPONENT_SELECTOR,
   STYLE_URL_SELECTOR,

lib/rules/independent-folders.js

@@ -4,7 +4,7 @@
  */
 'use strict';
 
-const path = require('path');
+const path = require('node:path');
 
 const isUnderPath = (folderPath, targetPath) => {
   const relative = path.relative(folderPath, targetPath);
@@ -87,8 +87,8 @@ module.exports = {
             buildReport(
               node,
               featureFolderIndex !== -1 ? featureFolders[featureFolderIndex] : sharedFolders[sharedFolderIndex],
-              otherFeatureFolders[featureFolderImportedIndex]
-            )
+              otherFeatureFolders[featureFolderImportedIndex],
+            ),
           );
         }
       },

lib/rules/ngx-component-display.js

@@ -70,7 +70,7 @@ module.exports = {
 
         // Try to get the HostBinding decorator
         const decorator = (displayNode.decorators || []).find(
-          (decorator) => decorator.expression.callee.name === 'HostBinding'
+          (decorator) => decorator.expression.callee.name === 'HostBinding',
         );
 
         if (!decorator) {

lib/rules/no-indexed-access-on-enums.js

@@ -5,6 +5,7 @@
  */
 'use strict';
 
+const ts = require('typescript');
 const moreInfo = `More info: https://github.com/criteo/eslint-plugin-criteo#no-indexed-access-on-enums`;
 
 module.exports = {

lib/rules/no-spreading-accumulators.js

@@ -12,13 +12,14 @@ module.exports = {
     type: 'problem',
     fixable: 'code',
     schema: [],
+    messages: {
+      objectMessage: `Creating a new object by spreading the previous accumulator at every iteration of a .reduce() call has O(n^2) time & spatial complexity. If possible, make this O(n) by assigning to the existing accumulator or use mappedBy() or mappedByUnique() instead of .reduce(). ${moreInfo}`,
+      arrayMessage: `Creating a new array by spreading the previous accumulator at every iteration of a .reduce() call has O(n^2) time & spatial complexity. If possible, make this O(n) by pushing to the existing accumulator instead. ${moreInfo}`,
+    },
   },
   create: function (context) {
     return {
       'CallExpression:has([callee.property.name=reduce])[arguments] > ArrowFunctionExpression'(node) {
-        const objectMessage = `Creating a new object by spreading the previous accumulator at every iteration of a .reduce() call has O(n^2) time & spatial complexity. If possible, make this O(n) by assigning to the existing accumulator or use mappedBy() or mappedByUnique() instead of .reduce(). ${moreInfo}`;
-        const arrayMessage = `Creating a new array by spreading the previous accumulator at every iteration of a .reduce() call has O(n^2) time & spatial complexity. If possible, make this O(n) by pushing to the existing accumulator instead. ${moreInfo}`;
-
         // only fetch the source code if getNodeText is called, and only fetch it once if we do
         const sourceCode = {
           _source: null,
@@ -29,10 +30,10 @@ module.exports = {
           },
         };
 
-        const getReportConfig = (spreadNode, fix, message) => ({
+        const getReportConfig = (spreadNode, fix, messageId) => ({
           node: spreadNode.argument,
           loc: spreadNode.loc,
-          message,
+          messageId,
           fix,
         });
 
@@ -83,7 +84,7 @@ module.exports = {
             const nonSpreadPropertyTexts = expression.properties
               .filter((o, i) => i != spreadIndex)
               .map(
-                (o) => `${arrowFnFirstArgName}[${sourceCode.getNodeText(o.key)}] = ${sourceCode.getNodeText(o.value)}`
+                (o) => `${arrowFnFirstArgName}[${sourceCode.getNodeText(o.key)}] = ${sourceCode.getNodeText(o.value)}`,
               );
             if (nonSpreadPropertyTexts.length <= 0) return undefined;
 
@@ -92,7 +93,7 @@ module.exports = {
             const fix = (fixer) => [fixer.replaceTextRange(arrowFn.range, newArrowFnText)];
             return fix;
           };
-          const reportConfig = getReportConfig(spreadNode, getObjectFix(), objectMessage);
+          const reportConfig = getReportConfig(spreadNode, getObjectFix(), 'objectMessage');
           return context.report(reportConfig);
         } else if (expression.type === 'ArrayExpression') {
           let spreadIndex = null;
@@ -130,13 +131,13 @@ module.exports = {
             if (!nonSpreadElementTexts || nonSpreadElementTexts.length <= 0) return undefined;
 
             const bodyText = `${arrowFnFirstArgName}.push(${nonSpreadElementTexts.join(
-              ', '
+              ', ',
             )}); return ${arrowFnFirstArgName};`;
             const newArrowFnText = `(${paramsText}) => { ${bodyText} }`;
             const fix = (fixer) => [fixer.replaceTextRange(arrowFn.range, newArrowFnText)];
             return fix;
           };
-          const reportConfig = getReportConfig(spreadNode, getArrayFix(), arrayMessage);
+          const reportConfig = getReportConfig(spreadNode, getArrayFix(), 'arrayMessage');
           return context.report(reportConfig);
         }
       },