Fix: Fix port parsing by using strconv.ParseUint

Christian Roessner · Christian Roessner · commit 1926e8e37f2d · 2024-10-16T17:15:58.000+02:00
Changed the port parsing method from strconv.Atoi to strconv.ParseUint. This ensures that port numbers are correctly interpreted as unsigned integers, preventing potential issues with negative values.

Signed-off-by: Christian Roessner &lt;c@roessner.co&gt;
diff --git a/server/lualib/connmgr/netstats.go b/server/lualib/connmgr/netstats.go
@@ -244,7 +244,7 @@ func (m *ConnectionManager) UpdateCounts() {
 			continue
 		}
 
-		port, err := strconv.Atoi(portStr)
+		port, err := strconv.ParseUint(portStr, 10, 32)
 		if err != nil {
 			logError(fmt.Sprintf("Invalid port number for destination '%s'", target), err)
 

Original file line number	Diff line number	Diff line change
`@@ -244,7 +244,7 @@ func (m *ConnectionManager) UpdateCounts() {`
`244`	`244`	`continue`
`245`	`245`	`}`
`246`	`246`
`247`		`- port, err := strconv.Atoi(portStr)`
	`247`	`+ port, err := strconv.ParseUint(portStr, 10, 32)`
`248`	`248`	`if err != nil {`
`249`	`249`	`logError(fmt.Sprintf("Invalid port number for destination '%s'", target), err)`
`250`	`250`