Replies: 1 comment 4 replies
-
|
Thank you for trying to contribute to this project! This seems to be a new issue for some users on GitHub, not just our repo It might be some side effect of GitHub fighting spam coming in via pull requests, but I don't know Can you point me to your repository to see what I can do? |
Beta Was this translation helpful? Give feedback.
4 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
We have implemented a small feature and would like to share it with community. But, we can't make pull request:
Validation failed: must be a collaboratorSo, question is: how to become a collaborator? May be I have missed, but I did not find anything about that... :/
What's PR all about?
It's about this issue: https://developer.apple.com/documentation/swift/renaming-objective-c-apis-for-swift
If I'm using generated code in Swift project, then Swift will rename my methods into something else (they have some naming rules). That, basically brakes all thing: API then looking totally different. There is a macro
NS_SWIFT_NAME, where you can put a name, which Swift will use (something like "I know what I'm doing. Please, Swift, leave method name as it is written in thos macro."). So, there is an option for that: to add or not to add this macro to every method of API.Beta Was this translation helpful? Give feedback.
All reactions