You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, call cancelling is implemented with a simple cancel() method on the returned Promise object. This is not perfect for the following reasons:
The cancel() method is "lost" after calling .then() on the promise
when calling cancel(), it is impossible to specify the reason with which the original promise will get rejected, so one must experiment/look in the library code to see that it is always a new Error("Cancelled")
(I don't know if this is relevant, but @types/autobahn will need to get updated anyways, too, as it doesn't declare the cancel() method, and wouldn't have the AbortSignal parameter either)
The text was updated successfully, but these errors were encountered:
Currently, call cancelling is implemented with a simple
cancel()
method on the returned Promise object. This is not perfect for the following reasons:cancel()
method is "lost" after calling.then()
on the promisecancel()
, it is impossible to specify thereason
with which the original promise will get rejected, so one must experiment/look in the library code to see that it is always anew Error("Cancelled")
I think it would be fairly easy to implement this: https://developer.mozilla.org/en-US/docs/Web/API/AbortSignal#implementing_an_abortable_api
(I don't know if this is relevant, but
@types/autobahn
will need to get updated anyways, too, as it doesn't declare thecancel()
method, and wouldn't have theAbortSignal
parameter either)The text was updated successfully, but these errors were encountered: