Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDS dbinstance: Check only major version if AutoMinorVersionUpgrade is true #1541

Merged

Conversation

akesser
Copy link
Contributor

@akesser akesser commented Oct 27, 2022

Description of your changes

If a rds dbinstance is deployed with AutoMinorVersionUpgrade set to true, and aws updates the minor version, the controller thinks there is a change. In this pull request, the isUpToDate method is updated to check only the major version of the db in this case.

Fixes #832

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Tested manually

Copy link
Member

@haarchri haarchri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested in our environment

André Kesser added 2 commits October 28, 2022 14:33
Signed-off-by: André Kesser <[email protected]>
@akesser akesser force-pushed the feature/db-instance-minor-updates branch from d4ebe96 to a19bd09 Compare October 28, 2022 12:35
Signed-off-by: André Kesser <[email protected]>
@haarchri haarchri merged commit d3cb664 into crossplane-contrib:master Oct 28, 2022
@andy-townsend
Copy link

I have autoMinorVersionUpgrade: true set on an RDSInstance that I've deployed as Postgres 15.2. If I manually upgrade the instance in the console to 15.3 via the AWS console (as AWS would presumably do in the next maintenance window), then the CR just goes into a Synced: False status and just see this sort of error on the CR.

Message:               update failed: cannot modify RDS instance: api error InvalidParameterCombination: Cannot upgrade postgres from 15.3 to 15.2

Is there something I've missed here as the PR seems to suggest that this shouldn't be the case now? @haarchri

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RDSInstance is in synced:false state because Cannot upgrade postgres from 12.7 to 12.5
3 participants